ajantha-bhat commented on code in PR #8673:
URL: https://github.com/apache/iceberg/pull/8673#discussion_r1341649516
##########
api/src/main/java/org/apache/iceberg/ManifestFile.java:
##########
@@ -49,7 +49,7 @@ public interface ManifestFile {
Types.LongType.get(),
"Lowest sequence number in the manifest");
Types.NestedField SNAPSHOT_ID =
- optional(
+ required(
Review Comment:
> We just updated it a week ago, but I think that's incorrect:
https://github.com/apache/iceberg/pull/8600
I thought it was optional from the beginning and hence asked about
compatibility. Didn't know it was recently modified. Compatibility shouldn't
matter now.
> My point is that the code should follow the spec, and not the other way
around
Agree.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
