nastra commented on code in PR #8299:
URL: https://github.com/apache/iceberg/pull/8299#discussion_r1296753304
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -122,6 +122,9 @@ public void testCreateTableBuilder() throws Exception {
assertThat(table.spec().fields()).hasSize(1);
assertThat(table.properties()).containsEntry("key1", "value1");
assertThat(table.properties()).containsEntry("key2", "value2");
+ // Default Parquet compression is explicitly set for new tables
+ assertThat(table.properties().get(TableProperties.PARQUET_COMPRESSION))
Review Comment:
minor:
`assertThat(table.properties()).containsEntry(TableProperties.PARQUET_COMPRESSION,
TableProperties.PARQUET_COMPRESSION_DEFAULT_SINCE_1_4_0)` is usually
preferrable, because it will print the content of properties when the assertion
ever fails
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
