aokolnychyi commented on code in PR #8299:
URL: https://github.com/apache/iceberg/pull/8299#discussion_r1304903073


##########
core/src/main/java/org/apache/iceberg/TableProperties.java:
##########
@@ -143,6 +143,7 @@ private TableProperties() {}
   public static final String PARQUET_COMPRESSION = 
"write.parquet.compression-codec";
   public static final String DELETE_PARQUET_COMPRESSION = 
"write.delete.parquet.compression-codec";
   public static final String PARQUET_COMPRESSION_DEFAULT = "gzip";
+  public static final String PARQUET_COMPRESSION_DEFAULT_SINCE_1_4_0 = "zstd";

Review Comment:
   Let me think. I do like the name but I also wonder if it sends a message the 
new default applies to all existing tables that did not provide a default 
value. It is probably not what happens as we only use this value in new tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to