aokolnychyi commented on code in PR #8299:
URL: https://github.com/apache/iceberg/pull/8299#discussion_r1294839051
##########
.palantir/revapi.yml:
##########
@@ -801,6 +801,11 @@ acceptedBreaks:
- code: "java.method.removed"
old: "method org.apache.iceberg.view.ViewBuilder
org.apache.iceberg.view.ViewBuilder::withQueryColumnNames(java.util.List<java.lang.String>)"
justification: "Acceptable break due to updating View APIs and the View
Spec"
+ org.apache.iceberg:iceberg-core:
+ - code: "java.field.constantValueChanged"
Review Comment:
Another idea could be to add a new constant for new tables and persist the
codec only during table creation, while still relying on the old
`PARQUET_COMPRESSION_DEFAULT` for existing tables.
That way we won't have to change `SnapshotProducer` and encode old values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
