aokolnychyi commented on code in PR #8299:
URL: https://github.com/apache/iceberg/pull/8299#discussion_r1295048996


##########
core/src/main/java/org/apache/iceberg/BaseMetastoreCatalog.java:
##########
@@ -149,6 +149,12 @@ public BaseMetastoreCatalogTableBuilder(TableIdentifier 
identifier, Schema schem
       this.identifier = identifier;
       this.schema = schema;
       this.tableProperties.putAll(tableDefaultProperties());
+
+      // Explicitly set default Parquet compression codecs for new tables

Review Comment:
   Well, the problem here is that we update multiple places with the same logic 
and it only covers some implementations. I am not sure how I feel about 
changing `TableMetadata` either. Let me think.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to