ankitsol commented on code in PR #7528:
URL: https://github.com/apache/hbase/pull/7528#discussion_r2620331416
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java:
##########
@@ -216,7 +216,7 @@ public int getTimeout() {
* the context are assumed to be persisted in the target cluster.
Review Comment:
@Apache9 This seems to be a good approach to me. We also want to move ahead
with time/size, both the options.
For implementing time based approach, I need one clarity. Should this
counter run in a separate thread since this would be independent of
`shipEdits()` logic?
Another question I have is I need to save this context of time and size
somewhere, do you recommend it to be in`ReplicationSourceShipper` or
`ReplicationSource`?
cc: @anmolnar @vinayakphegde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
