anmolnar commented on code in PR #7528:
URL: https://github.com/apache/hbase/pull/7528#discussion_r2611242472


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java:
##########
@@ -216,7 +216,7 @@ public int getTimeout() {
    * the context are assumed to be persisted in the target cluster.

Review Comment:
   You cannot close the writer every time when something was shipped, because 
closing and re-opening the same stream is a costly operation if even supported. 
We have to wait for enough data to be shipped (file size limit) or the 
configured time spent (time limit) before closing the current stream and 
opening a new one. This is controlled by the replication endpoint itself.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to