anmolnar commented on code in PR #7528:
URL: https://github.com/apache/hbase/pull/7528#discussion_r2611246722
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/HBaseInterClusterReplicationEndpoint.java:
##########
@@ -459,7 +458,8 @@ public ReplicationResult replicate(ReplicateContext
replicateContext) {
try {
// replicate the batches to sink side.
parallelReplicate(replicateContext, batches);
- return ReplicationResult.COMMITTED;
+
getReplicationSource().cleanupHFileRefsAndPersistOffsets(replicateContext.getEntries());
Review Comment:
> But for me, I prefer we follow the old way where call this in
ReplicationSourceShipper.
I think it's doable. @ankitsol ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
