Apache9 commented on code in PR #7528:
URL: https://github.com/apache/hbase/pull/7528#discussion_r2614816456
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ReplicationEndpoint.java:
##########
@@ -216,7 +216,7 @@ public int getTimeout() {
* the context are assumed to be persisted in the target cluster.
Review Comment:
So you also need to change the logic in ReplicationSourceShipper, to not
always record the offset after shipping. And I do not think this can 'ONLY' be
controlled by replication endpoint, in ReplicationSourceShipper you know the
size of the WALEntries, and you also know how much time has elapsed after the
last recording, so it is easy to implement the logic?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
