NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222318266
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
> We do not need to use java 8 for protobuf?
Sorry? But we are already doing that. We are using java 8 for unsafe and
protobuf both.
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+ <java.min.version>1.8</java.min.version>
+ <java.secondary.version>17</java.secondary.version>
Review Comment:
> sure will rename as java.version
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
