NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222270829
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
If I do not set them it fails for with error:
```
[INFO] --- compiler:3.13.0:compile (default-compile) @ hbase-shaded-protobuf
---
[INFO] Toolchain in maven-compiler-plugin:
JDK[/Users/nihjain/adoptopenjdk-8.jdk/Contents/Home]
[INFO] Recompiling the module because of changed source code.
[INFO] Compiling 206 source files with javac [forked debug release 8] to
target/classes
[INFO] -------------------------------------------------------------
[WARNING] COMPILATION WARNING :
[INFO] -------------------------------------------------------------
[WARNING] [options] bootstrap class path not set in conjunction with -source
1.7
[INFO] 1 warning
[INFO] -------------------------------------------------------------
[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
/Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33]
error: lambda expressions are not supported in -source 1.7
(use -source 8 or higher to enable lambda expressions)
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO]
------------------------------------------------------------------------
[INFO] Reactor Summary for Apache HBase Third-Party Libs 4.1.12-SNAPSHOT:
[INFO]
[INFO] Apache HBase Third-Party Libs ...................... SUCCESS [ 1.254
s]
[INFO] Apache HBase Patched and Relocated (Shaded) Protobuf FAILURE [ 5.708
s]
[INFO] Apache HBase Relocated (Shaded) Netty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) netty-tcnative Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) GSON Libs .......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Third-party Miscellaneous Libs SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty Libs ......... SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: Core SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jetty 12+ Libs: EE8 SKIPPED
[INFO] Apache HBase Relocated (Shaded) Jersey Libs ........ SKIPPED
[INFO] Apache HBase Relocated (Shaded) jackson-jaxrs-json-provider SKIPPED
[INFO] Apache HBase Drop-in noop HTrace replacement ....... SKIPPED
[INFO] Apache HBase Unsafe Wrapper ........................ SKIPPED
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 7.207 s
[INFO] Finished at: 2025-07-22T17:13:58+05:30
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.13.0:compile (default-compile)
on project hbase-shaded-protobuf: Compilation failure
[ERROR]
/Users/nihjain/code/os/hbase-thirdparty/hbase-shaded-protobuf/src/main/java/com/google/protobuf/ProtobufToStringOutput.java:[18,33]
error: lambda expressions are not supported in -source 1.7
[ERROR] (use -source 8 or higher to enable lambda expressions)
[ERROR]
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the
command
[ERROR] mvn <args> -rf :hbase-shaded-protobuf
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
