NihalJain commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222326562
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
> Should I remove from main pom.xml and just set below explicitly for jdk 8
modules?
>
> ```
> <maven.compiler.source>${java.release.version}</maven.compiler.source>
> <maven.compiler.target>${java.release.version}</maven.compiler.target>
> ```
Updated PR to remove compiler source and target from main pom.xml and moved
to only reqd modules!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
