Apache9 commented on code in PR #142:
URL: https://github.com/apache/hbase-thirdparty/pull/142#discussion_r2222108566
##########
pom.xml:
##########
@@ -125,8 +127,19 @@
<maven.javadoc.skip>true</maven.javadoc.skip>
<maven.build.timestamp.format>yyyy-MM-dd'T'HH:mm</maven.build.timestamp.format>
<buildDate>${maven.build.timestamp}</buildDate>
- <compileSource>1.8</compileSource>
- <java.min.version>${compileSource}</java.min.version>
+ <!-- Project level compilation properties -->
+
<hbase.unsafe.and.protobuf.java.version>1.8</hbase.unsafe.and.protobuf.java.version>
+ <java.secondary.version>17</java.secondary.version>
+ <java.release.version>8</java.release.version>
+ <maven.compiler.source>${java.release.version}</maven.compiler.source>
Review Comment:
This is for hbase-unsafe only? It should be 8 or 1.8?
##########
hbase-shaded-protobuf/pom.xml:
##########
@@ -29,6 +29,13 @@
<artifactId>hbase-shaded-protobuf</artifactId>
<name>Apache HBase Patched and Relocated (Shaded) Protobuf</name>
<description>Pulls down protobuf, patches it, compiles, and then
relocates/shades.</description>
+ <properties>
+ <!-- Override parent's JDK 17 settings to force JDK 8 for
hbase-shaded-protobuf.
Review Comment:
So protobuf also uses Unsafe? What is the compile error you see?
##########
pom.xml:
##########
@@ -245,11 +280,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
- <version>3.11.0</version>
- <configuration>
- <source>1.8</source>
- <target>1.8</target>
- </configuration>
+ <version>3.13.0</version>
Review Comment:
Then do we still need to set maven.compiler.source and maven.compiler.target?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
