droudnitsky commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2100523369
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
- updateCachedLocations(server, regionName, row,
Review Comment:
Yeah `AsyncRequestFutureImpl` is tricky .. I have spent more time than I
care to admit to understand it better. Passing the exception to
`updateCachedLocations` so it gets accounted for in the cache clearing
exception metric sounds good, that is a nice improvement, makes sense to me 👍
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -764,13 +763,18 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
- Throwable t, boolean clearServerCache) {
+ Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+ boolean clearServerCache = ClientExceptionsUtil.isMetaClearingException(t);
// Do not update cache if exception is from failing to submit action to
thread pool
if (clearServerCache) {
cleanServerCache(server, t);
+
+ if (LOG.isTraceEnabled()) {
Review Comment:
Hernan looks to have that covered through `updateCachedLocations` -
https://github.com/apache/hbase/pull/6961/files#r2096239861
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
