hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2096242427
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
- updateCachedLocations(server, regionName, row,
Review Comment:
Ah you're right. This code path is really tricky to reason about. Between
the UnknownExceptions in the meta cache clear metrics, and the lack of logging,
it's really difficult to identify what is causing these meta cache clears. I
think I'm going to re-purpose this PR to simply add some logging + avoid
passing in `null` as the meta exception in this code path. That should
hopefully help us shed some light on the high number of meta cache clears we're
seeing at my company, and will illuminate a path forward.
@droudnitsky does that make sense to you?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
