hgromer commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2096239861
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -783,8 +787,7 @@ private void receiveGlobalFailure(MultiAction rsActions,
ServerName server, int
// any of the regions in the MultiAction and do not update cache if
exception is
// from failing to submit action to thread pool
if (clearServerCache) {
- updateCachedLocations(server, regionName, row,
- ClientExceptionsUtil.isMetaClearingException(t) ? null : t);
+ updateCachedLocations(server, regionName, row, t);
Review Comment:
What we'll do is basically "mask" the cache clearing exception by report an
`UnknownException`. The code for that lives in the [metrics
class](https://github.com/apache/hbase/blob/b21ba71f73881336345fd5dd7d647910b3058e05/hbase-client/src/main/java/org/apache/hadoop/hbase/client/MetricsConnection.java#L802).
It's annoying b/c that coupled with the lack of any logging in this code path
makes it really difficult to determine what caused these meta cache clears.
##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName
server, int numAttempt,
* @param t the throwable (if any) that caused the resubmit
*/
private void receiveGlobalFailure(MultiAction rsActions, ServerName server,
int numAttempt,
- Throwable t, boolean clearServerCache) {
+ Throwable t) {
errorsByServer.reportServerError(server);
Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES :
Retry.NO_RETRIES_EXHAUSTED;
+ boolean clearServerCache = false;
+
+ if (!(t instanceof RejectedExecutionException)) {
Review Comment:
Noted, adding that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
