ndimiduk commented on code in PR #6961:
URL: https://github.com/apache/hbase/pull/6961#discussion_r2077349420


##########
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncRequestFutureImpl.java:
##########
@@ -764,9 +763,14 @@ private void failAll(MultiAction actions, ServerName 
server, int numAttempt,
    * @param t          the throwable (if any) that caused the resubmit
    */
   private void receiveGlobalFailure(MultiAction rsActions, ServerName server, 
int numAttempt,
-    Throwable t, boolean clearServerCache) {
+    Throwable t) {
     errorsByServer.reportServerError(server);
     Retry canRetry = errorsByServer.canTryMore(numAttempt) ? Retry.YES : 
Retry.NO_RETRIES_EXHAUSTED;
+    boolean clearServerCache = false;
+
+    if (!(t instanceof RejectedExecutionException)) {

Review Comment:
   I think it would be better if you instead push `RejectedExecutionException` 
down into `ClientExceptionsUtil.isMetaClearingException`.
   
   How about adding another collection of execution-exceptions for the family 
of various ExecutorService interaction errors, like is done with 
networking/connection exceptions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to