stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1814778568


##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
       <artifactId>hbase-shaded-mapreduce</artifactId>
     </dependency>
     <!-- Intra-project dependencies -->
+    <!-- We don't really add this to assembly tarball, we retain it here just 
to dump it into

Review Comment:
   This looks iffy and fragile.
   What about adding a new module which is used only for generating 
cached-classpath  instead ?
   Or maybe using hbase-it, IF that already has all the dependencies we need 
for cached-classpath  ?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to