stoty commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1832179812
##########
hbase-assembly/pom.xml:
##########
@@ -48,13 +48,17 @@
<artifactId>hbase-shaded-mapreduce</artifactId>
</dependency>
<!-- Intra-project dependencies -->
+ <!-- We don't really add this to assembly tarball, we retain it here just
to dump it into
Review Comment:
I still don't like it, but I checked that we explictly list the dependencies
to be included in the descriptors, so this is unlikely to cause regressions.
I'm going to work on the assemblies in the next sub-task anyway, I will
check if can find a more elegant solution then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
