NihalJain commented on code in PR #6184:
URL: https://github.com/apache/hbase/pull/6184#discussion_r1809320827
##########
hbase-assembly/src/main/assembly/client.xml:
##########
@@ -45,6 +45,8 @@
<dependencySets>
<dependencySet>
<excludes>
+ <exclude>org.apache.hadoop:*:test-jar</exclude>
Review Comment:
We don't really hit this, just a safety check then.
```
[INFO] --- assembly:3.2.0:single (default-cli) @ hbase-assembly ---
[WARNING] Parameter 'finalName' is read-only, must not be used in
configuration
[INFO] Reading assembly descriptor: src/main/assembly/hadoop-three-compat.xml
[INFO] Reading assembly descriptor: src/main/assembly/client.xml
[WARNING] The following patterns were never triggered in this artifact
exclusion filter:
o 'org.apache.hadoop:*:test-jar'
o 'org.apache.hbase:*:test-jar'
o 'log4j:log4j'
o 'org.apache.htrace:htrace-core4'
o 'org.apache.htrace:htrace-core'
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
