NihalJain commented on PR #6184:
URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427505247
Updated Info:
1) List of jars removed with this patch from our assembly
```
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-testing-util-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-it-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-hadoop-compat-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hbase-annotations-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minikdc-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-jobclient-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-hdfs-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT/lib/asm-analysis-9.3.jar
```
and
```
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/mockito-core-4.11.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/junit-4.13.2.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/test/hamcrest-core-1.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-servlet-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/websocket-server-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/mssql-jdbc-6.2.1.jre7.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/leveldbjni-all-1.8.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/json-io-2.5.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jna-5.2.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-plus-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-jndi-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/jetty-annotations-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-client-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax.websocket-api-1.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-server-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/javax-websocket-client-impl-9.4.48.v20220622.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/java-util-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/HikariCP-java7-2.4.12.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-zookeeper-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-server-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-procedure-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-mapreduce-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-common-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hbase-asyncfs-4.0.0-alpha-1-SNAPSHOT-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-web-proxy-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-timelineservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-tests-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-resourcemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-nodemanager-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-yarn-server-applicationhistoryservice-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-registry-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-minicluster-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-shuffle-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-jobclient-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-hs-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-common-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-mapreduce-client-app-3.3.5.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/hadoop-common-3.3.5-tests.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/geronimo-jcache_1.0_spec-1.0-alpha-1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/fst-2.50.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/ehcache-3.3.1.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/commons-csv-1.9.0.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-tree-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-commons-9.3.jar
./hbase-4.0.0-alpha-1-SNAPSHOT-client/lib/asm-analysis-9.3.jar
```
2) Size Comparison, master vs master with this PR::
```
705528 -rw-r--r--@ 1 nihaljain user 361228649 Oct 16 02:11
assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
682160 -rw-r--r--@ 1 nihaljain user 349262475 Oct 16 02:11
assembly_master/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
```
VS
```
629032 -rw-r--r--@ 1 nihaljain user 322063229 Oct 22 00:09
assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-bin.tar.gz
625944 -rw-r--r--@ 1 nihaljain user 320483247 Oct 22 00:09
assembly_HBASE-28433_v2/hbase-4.0.0-alpha-1-SNAPSHOT-client-bin.tar.gz
```
3) Diff of cached paths: EMPTY
```
hbase % diff <( cat assembly_master/cached_classpath.txt | sed -e
's/:/\n/g' | sort) <( cat assembly_HBASE-28433_v2/cached_classpath.txt | sed -e
's/:/\n/g' | sort )
hbase %
```
4) Started hbase cluster in standalone mode and tested following:
- From extracted bin:
- Started shell and verified basic CRUD
- Triggered IntegrationTestsDriver: Fails as expected
- Ran tools from last round of refactoring, no new issues seen
- From compiled source bin:
- Started shell and verified basic CRUD
- Triggered IntegrationTestsDriver and no failure observed.
Please let me know if I should verify anything else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
