NihalJain commented on PR #6184: URL: https://github.com/apache/hbase/pull/6184#issuecomment-2427428726
Summary of 4th commit: This commit addresses the review comments and improves the handling of how we can run IT, other tools in dev environment post this change. Now we revert back to directly using cached_classpath.txt to load jars required during runtime (as before). NOTE: To ensures the content of cached_classpath.txt is same as without this patch (which was not the case until commit 3 as we were removing dependencies from hbase-assembly), we retain some jars (including test jars) in assembly pom.xml although we actually remove them during tarball creation. Only 1 review comment is pending: on checking whether *:test-jar is a safety check or if we really hit it. I have forgotten what was the case given I rasied v1 of this PR almost 2 months ago. Let me redo analysis and come back to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
