gvprathyusha6 commented on code in PR #5939:
URL: https://github.com/apache/hbase/pull/5939#discussion_r1773528276
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -227,8 +228,8 @@ public long getMaxMemStoreTS() {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public HStoreFile(FileSystem fs, Path p, Configuration conf, CacheConfig
cacheConf,
- BloomType cfBloomType, boolean primaryReplica) throws IOException {
- this(new StoreFileInfo(conf, fs, p, primaryReplica), cfBloomType,
cacheConf);
+ BloomType cfBloomType, boolean primaryReplica, StoreFileTracker sft)
throws IOException {
Review Comment:
Currently HStoreFile is tied to Hadoop FileSystem obj, it will be more
inline to send in the StoreFileTracker instance instead know?
Also then we need to send in the entire content of StoreContext to
HStoreFile constructor if we want to create StoreFileTracker instance inside
HStoreFile constructor.
Infact SFT instance currently doesnt have api for accessing its storeContext
outside, otherwise we can replace FS object in constructor with SFT object
directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
