wchevreuil commented on code in PR #5939:
URL: https://github.com/apache/hbase/pull/5939#discussion_r1771995129
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStoreFile.java:
##########
@@ -227,8 +228,8 @@ public long getMaxMemStoreTS() {
* @param primaryReplica true if this is a store file for primary replica,
otherwise false.
*/
public HStoreFile(FileSystem fs, Path p, Configuration conf, CacheConfig
cacheConf,
- BloomType cfBloomType, boolean primaryReplica) throws IOException {
- this(new StoreFileInfo(conf, fs, p, primaryReplica), cfBloomType,
cacheConf);
+ BloomType cfBloomType, boolean primaryReplica, StoreFileTracker sft)
throws IOException {
Review Comment:
Rather than adding this extra 'sft' parameter, and change every single
caller in the upper chain to now create/forward an SFT instance down here, can
we simply create the SFT instance in this HStoreFile constructor?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
