gvprathyusha6 commented on PR #5939: URL: https://github.com/apache/hbase/pull/5939#issuecomment-2368610253
> I'm sorry, but I'm struggling to understand the benefits of such a large refactoring. To me, the resulting code is looking more complex than before, with extra SFT instances now required in many places, even duplicating logic at some points (like [here](https://github.com/apache/hbase/pull/5939/files#diff-f899fc155a45169056889ed87723f61c86c529aacdcb0df3a9f3c180f30cff66R429). > > Is the plan just to get rid of HRegionFileSystem and put further responsibilities on SFT? @wchevreuil the plan here is to have the handling/abstraction of Reference/link files at the SFT layer, so that we can utilise this abstraction going forward to introduce [Virtual links for Reference/Link files](https://docs.google.com/document/d/18aHEv7w0RExV6nJbJaVnTR6NIqbiWHIVUvU7v9rvXAk/edit) using manifest file of FileBasedStoreFileTracker. >even duplicating logic at some points (like [here](https://github.com/apache/hbase/pull/5939/files#diff-f899fc155a45169056889ed87723f61c86c529aacdcb0df3a9f3c180f30cff66R429). let me check on this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
