wchevreuil commented on code in PR #5939:
URL: https://github.com/apache/hbase/pull/5939#discussion_r1771752710
##########
hbase-server/src/main/java/org/apache/hadoop/hbase/master/janitor/CatalogJanitor.java:
##########
@@ -422,7 +426,16 @@ private static Pair<Boolean, Boolean>
checkRegionReferences(MasterServices servi
try {
HRegionFileSystem regionFs = HRegionFileSystem
.openRegionFromFileSystem(services.getConfiguration(), fs, tabledir,
region, true);
- boolean references = regionFs.hasReferences(tableDescriptor);
+ ColumnFamilyDescriptor[] families = tableDescriptor.getColumnFamilies();
+ boolean references = false;
+ for (ColumnFamilyDescriptor cfd : families) {
+ StoreFileTracker sft =
StoreFileTrackerFactory.create(services.getConfiguration(),
+ tableDescriptor,
ColumnFamilyDescriptorBuilder.of(cfd.getNameAsString()), regionFs);
+ references = references || sft.hasReferences();
+ if (references) {
+ break;
+ }
+ }
Review Comment:
Should also be moved to HRegionFileSystem.hasReferences(), like other
methods did?
Additional question: Is it guaranteed that we don't have more than one SFT
instance for the same store at any point in time? Because the file based SFT
impl relies on the fact it's the single instance manipulating its meta files.
If we have multiple instances of SFT for the same store, it could lead to
inconsistencies, where one of the instances update the meta file, than the
others would be looking at an outdated state of the meta files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
