Apache-HBase commented on PR #6258:
URL: https://github.com/apache/hbase/pull/6258#issuecomment-2362140401

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 48s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  1s |  |  No case conflicting files 
found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  
|
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain 
any @author tags.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  |  Patch does not have any 
anti-patterns.  |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 23s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   4m  3s |  |  master passed  |
   | +1 :green_heart: |  compile  |  11m 19s |  |  master passed  |
   | +1 :green_heart: |  checkstyle  |   1m 13s |  |  master passed  |
   | +1 :green_heart: |  spotbugs  |  21m 38s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   1m 12s |  |  branch has no errors when 
running spotless:check.  |
   | -0 :warning: |  patch  |   2m 25s |  |  Used diff version of patch file. 
Binary files and potentially other changes not applied. Please rebase and 
squash commits if necessary.  |
   |||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 19s |  |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   3m 18s |  |  the patch passed  |
   | -1 :x: |  compile  |   9m  0s | 
[/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/patch-compile-root.txt)
 |  root in the patch failed.  |
   | -0 :warning: |  javac  |   9m  0s | 
[/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/patch-compile-root.txt)
 |  root in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  1s |  |  The patch has no blanks 
issues.  |
   | -0 :warning: |  checkstyle  |   1m 28s | 
[/results-checkstyle-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/results-checkstyle-root.txt)
 |  root: The patch generated 46 new + 66 unchanged - 39 fixed = 112 total (was 
105)  |
   | +1 :green_heart: |  xmllint  |   0m  1s |  |  No new issues.  |
   | -1 :x: |  spotbugs  |   2m 38s | 
[/new-spotbugs-hbase-server.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/new-spotbugs-hbase-server.html)
 |  hbase-server generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)  |
   | -1 :x: |  spotbugs  |  11m 45s | 
[/new-spotbugs-root.html](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/new-spotbugs-root.html)
 |  root generated 13 new + 0 unchanged - 0 fixed = 13 total (was 0)  |
   | +1 :green_heart: |  hadoopcheck  |  10m 49s |  |  Patch does not cause any 
errors with Hadoop 3.3.6 3.4.0.  |
   | +1 :green_heart: |  spotless  |   0m 44s |  |  patch has no errors when 
running spotless:check.  |
   |||| _ Other Tests _ |
   | +1 :green_heart: |  asflicense  |   1m 52s |  |  The patch does not 
generate ASF License warnings.  |
   |  |   |  98m 45s |  |  |
   
   
   | Reason | Tests |
   |-------:|:------|
   | SpotBugs | module:hbase-server |
   |  |  Random object created and used only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][])  At LoadTestKVGenerator.java:only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][])  At LoadTestKVGenerator.java:[line 111] |
   | SpotBugs | module:root |
   |  |  Integral division result cast to double or float in 
org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions)
  At PerformanceEvaluation.java:double or float in 
org.apache.hadoop.hbase.PerformanceEvaluation.calculateRowsAndSize(PerformanceEvaluation$TestOptions)
  At PerformanceEvaluation.java:[line 3154] |
   |  |  org.apache.hadoop.hbase.PerformanceEvaluation$RunResult defines 
compareTo(PerformanceEvaluation$RunResult) and uses Object.equals()  At 
PerformanceEvaluation.java:Object.equals()  At PerformanceEvaluation.java:[line 
250] |
   |  |  Random object created and used only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][])  At LoadTestKVGenerator.java:only once in 
org.apache.hadoop.hbase.util.LoadTestKVGenerator.getValueForRowColumn(int, 
byte[][])  At LoadTestKVGenerator.java:[line 111] |
   |  |  
org.apache.hadoop.hbase.util.LoadTestTool.DEFAULT_NUM_REGIONS_PER_SERVER isn't 
final but should be  At LoadTestTool.java:be  At LoadTestTool.java:[line 167] |
   |  |  
org.apache.hadoop.hbase.util.MultiThreadedAction.verifyResultAgainstDataGenerator(Result,
 boolean, boolean) concatenates strings using + in a loop  At 
MultiThreadedAction.java:using + in a loop  At MultiThreadedAction.java:[line 
415] |
   |  |  Integral division result cast to double or float in 
org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run()  At 
MultiThreadedAction.java:double or float in 
org.apache.hadoop.hbase.util.MultiThreadedAction$ProgressReporter.run()  At 
MultiThreadedAction.java:[line 206] |
   |  |  
org.apache.hadoop.hbase.util.MultiThreadedReader$HBaseReaderThread.createGet(long)
 concatenates strings using + in a loop  At MultiThreadedReader.java:in a loop  
At MultiThreadedReader.java:[line 318] |
   |  |  Dead store to rowKey in 
org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get,
 boolean, long)  At 
MultiThreadedReaderWithACL.java:org.apache.hadoop.hbase.util.MultiThreadedReaderWithACL$HBaseReaderThreadWithACL.queryKey(Get,
 boolean, long)  At MultiThreadedReaderWithACL.java:[line 91] |
   |  |  Inconsistent synchronization of 
org.apache.hadoop.hbase.util.MultiThreadedUpdater.writer; locked 75% of time  
Unsynchronized access at MultiThreadedUpdater.java:75% of time  Unsynchronized 
access at MultiThreadedUpdater.java:[line 80] |
   |  |  Unwritten field:MultiThreadedUpdaterWithACL.java:[line 94] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[])  At 
WALPerformanceEvaluation.java:is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.run(String[])  At 
WALPerformanceEvaluation.java:[line 244] |
   |  |  Format string should use %n rather than n in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit()  At 
WALPerformanceEvaluation.java:rather than n in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation.printUsageAndExit()  At 
WALPerformanceEvaluation.java:[line 414] |
   |  |  Exception is caught when Exception is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run()  At 
WALPerformanceEvaluation.java:is not thrown in 
org.apache.hadoop.hbase.wal.WALPerformanceEvaluation$WALPutBenchmark.run()  At 
WALPerformanceEvaluation.java:[line 171] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/artifact/yetus-general-check/output/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/6258 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint 
spotless spotbugs checkstyle compile hadoopcheck hbaseanti |
   | uname | Linux 67bb151ff18f 5.4.0-195-generic #215-Ubuntu SMP Fri Aug 2 
18:28:05 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / d6d6246362d834afebcbbc55647d9cd139dcbd99 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | Max. process+thread count | 190 (vs. ulimit of 30000) |
   | modules | C: hbase-common hbase-client hbase-balancer hbase-asyncfs 
hbase-server hbase-mapreduce hbase-diagnostics hbase-testing-util . 
hbase-assembly hbase-it U: . |
   | Console output | 
https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6258/3/console 
|
   | versions | git=2.34.1 maven=3.9.8 spotbugs=4.7.3 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to