NihalJain commented on code in PR #6258:
URL: https://github.com/apache/hbase/pull/6258#discussion_r1767481488
##########
hbase-mapreduce/src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat2.java:
##########
@@ -554,18 +554,43 @@ private byte[][] generateRandomStartKeys(int numKeys) {
// first region start key is always empty
ret[0] = HConstants.EMPTY_BYTE_ARRAY;
for (int i = 1; i < numKeys; i++) {
- ret[i] =
- PerformanceEvaluation.generateData(random,
PerformanceEvaluation.DEFAULT_VALUE_LENGTH);
+ ret[i] = generateData(random, DEFAULT_VALUE_LENGTH);
}
return ret;
}
+ /*
Review Comment:
I have tried to make local copies of such variable wherever i could find
shared usage
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
