NihalJain commented on code in PR #6258:
URL: https://github.com/apache/hbase/pull/6258#discussion_r1767472318


##########
hbase-common/src/main/java/org/apache/hadoop/hbase/io/crypto/KeyProviderForTesting.java:
##########
@@ -19,10 +19,12 @@
 
 import java.security.Key;
 import javax.crypto.spec.SecretKeySpec;
+import org.apache.yetus.audience.InterfaceAudience;
 
 /**
  * Return a fixed secret key for AES for testing.
  */
+@InterfaceAudience.Private
 public class KeyProviderForTesting implements KeyProvider {

Review Comment:
   Sure but this class is not good for prod use, should i rename to 
MockAesKeyProvider or something?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to