NihalJain commented on PR #6258: URL: https://github.com/apache/hbase/pull/6258#issuecomment-2362006345
> > I should also say -- we shouldn't be shy about having more maven modules. Let's have a common module for `scope:compile` and a common module that is for `scope:test`. Let's even keep each executable tool to its own module with its own explicit dependency list. It'll make maintaining/pruning them easier in the long term. Plus every module becomes an independent, parallel target for `mvn -T`. > > ``` > > hbase-diagnostics/ > > ├─ hbase-diagnostics-common/ > > ├─ hbase-diagnostics-testing-common/ > > ├─ hbase-performance-evaluation/ > > ├─ hbase-load-test-tool/ > > ├─ ... > > ``` > > As Duo is starting 3.0 preparations, maybe we should leave that for a later ticket. I'd prefer to make sure that these refactors land in 3.0. We can decide if we should also target this in current PR. I am okay to update based on this suggested change either here or as another task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@hbase.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org