[
https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17295910#comment-17295910
]
ASF GitHub Bot commented on GEODE-8971:
---------------------------------------
albertogpz commented on a change in pull request #6052:
URL: https://github.com/apache/geode/pull/6052#discussion_r588164850
##########
File path:
geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java
##########
@@ -174,7 +174,32 @@
*/
int GET_TRANSACTION_EVENTS_FROM_QUEUE_RETRIES =
Integer.getInteger(GeodeGlossary.GEMFIRE_PREFIX +
"get-transaction-events-from-queue-retries",
- 10);
+ 2);
+ /**
+ * Milliseconds to wait before retrying to get events for a transaction from
the
+ * gateway sender queue when group-transaction-events is true.
+ */
+ int GET_TRANSACTION_EVENTS_FROM_QUEUE_WAIT_TIME_MS =
+ Integer.getInteger(
+ GeodeGlossary.GEMFIRE_PREFIX +
"get-transaction-events-from-queue-wait-time-ms",
+ 1);
+
+ /**
+ * When group-transaction-events is set to true and the gateway sender is
stopped,
+ * there is a possibility that the stopping occurs such that for a
transaction,
+ * not all events belonging to it reach the queue. The reason would be that
+ * some reach the queue right before the sender is stopped and the rest do
not make
+ * it to the queue because the sender is just stopped.
+ * In order to prevent that the queue contains incomplete transactions
+ * due to the above circumstance, this parameter allows for a grace period
+ * of the number of milliseconds set in it before the gateway sender is
+ * actually stopped, in which only events to complete transactions are put
in the queue.
+ * Other events received in this period would be dropped.
Review comment:
Thanks Dave. Very good suggestion. I made a slight change in the last
sentence of your proposal but other than that, I took it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
> Key: GEODE-8971
> URL: https://issues.apache.org/jira/browse/GEODE-8971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> When the gateway sender is stopped there is a high probability that batches
> with incomplete transactions are sent even if group-transaction-events is
> enabled.
> The reason is that once the stop command reaches the gateway sender, it
> immediately stops queueing events, and this could happen in the middle of
> receiving events for the same transaction. If this is the case, some events
> for the transaction may have reached the queue right before the stop command
> was received and the rest of events for that transaction would not make it to
> the queue (they would be dropped) because they arrived right after the stop
> command was received at the gateway sender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
