[
https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17297273#comment-17297273
]
ASF GitHub Bot commented on GEODE-8971:
---------------------------------------
albertogpz commented on a change in pull request #6052:
URL: https://github.com/apache/geode/pull/6052#discussion_r589350876
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -702,44 +704,15 @@ public boolean put(Object object) throws
InterruptedException, CacheException {
boolean isDREvent = isDREvent(sender.getCache(), value);
String regionPath = value.getRegionPath();
- if (!isDREvent) {
- Region region = sender.getCache().getRegion(regionPath, true);
- regionPath = ColocationHelper.getLeaderRegion((PartitionedRegion)
region).getFullPath();
- }
- if (isDebugEnabled) {
- logger.debug("Put is for the region {}", regionPath);
- }
- if (!this.userRegionNameToShadowPRMap.containsKey(regionPath)) {
- if (isDebugEnabled) {
- logger.debug("The userRegionNameToshadowPRMap is {}",
userRegionNameToShadowPRMap);
- }
- logger.warn(
- "GatewaySender: Not queuing the event {}, as the region for which
this event originated is not yet configured in the GatewaySender",
- value);
- // does not put into queue
+ regionPath = getRegionPathForEventAndType(value, isDREvent, regionPath);
+ if (regionPath == null)
Review comment:
ok
##########
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java
##########
@@ -702,44 +704,15 @@ public boolean put(Object object) throws
InterruptedException, CacheException {
boolean isDREvent = isDREvent(sender.getCache(), value);
String regionPath = value.getRegionPath();
- if (!isDREvent) {
- Region region = sender.getCache().getRegion(regionPath, true);
- regionPath = ColocationHelper.getLeaderRegion((PartitionedRegion)
region).getFullPath();
- }
- if (isDebugEnabled) {
- logger.debug("Put is for the region {}", regionPath);
- }
- if (!this.userRegionNameToShadowPRMap.containsKey(regionPath)) {
- if (isDebugEnabled) {
- logger.debug("The userRegionNameToshadowPRMap is {}",
userRegionNameToShadowPRMap);
- }
- logger.warn(
- "GatewaySender: Not queuing the event {}, as the region for which
this event originated is not yet configured in the GatewaySender",
- value);
- // does not put into queue
+ regionPath = getRegionPathForEventAndType(value, isDREvent, regionPath);
+ if (regionPath == null)
return false;
- }
PartitionedRegion prQ = this.userRegionNameToShadowPRMap.get(regionPath);
int bucketId = value.getBucketId();
- Object key = null;
- if (!isDREvent) {
- key = value.getShadowKey();
-
- if ((Long) key == -1) {
- // In case of parallel we don't expect
- // the key to be not set. If it is the case then the event must be
coming
- // through listener, so return.
- if (isDebugEnabled) {
- logger.debug("ParallelGatewaySenderOrderedQueue not putting key {} :
Value : {}", key,
- value);
- }
- // does not put into queue
- return false;
- }
- } else {
- key = value.getEventId();
- }
+ Object key = getKeyForEventAndType(value, isDREvent);
+ if (key == null)
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
> Key: GEODE-8971
> URL: https://issues.apache.org/jira/browse/GEODE-8971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> When the gateway sender is stopped there is a high probability that batches
> with incomplete transactions are sent even if group-transaction-events is
> enabled.
> The reason is that once the stop command reaches the gateway sender, it
> immediately stops queueing events, and this could happen in the middle of
> receiving events for the same transaction. If this is the case, some events
> for the transaction may have reached the queue right before the stop command
> was received and the rest of events for that transaction would not make it to
> the queue (they would be dropped) because they arrived right after the stop
> command was received at the gateway sender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
