[
https://issues.apache.org/jira/browse/GEODE-8971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17294394#comment-17294394
]
ASF GitHub Bot commented on GEODE-8971:
---------------------------------------
albertogpz commented on pull request #6052:
URL: https://github.com/apache/geode/pull/6052#issuecomment-789556681
> Unless we have a real need to expose `TransactionId getTransactionId()`
and `boolean isLastEventInTransaction()` to the User (it's in a non-internal
package), then I would **_not_** add them to the `GatewayQueueEvent`.
>
> I would create a new `InternalGatewayQueueEvent` interface that extends
`GatewayQueueEvent` and add the two tx related methods to that internal
interface instead. Then you could define the predicate as
`Predicate<InternalGatewayQueueEvent>`.
>
> Adding `InternalGatewayQueueEvent` would probably require some follow-up
PRs that update the WAN code to use it internally. This would them be part of
longer term refactoring to improve the codebase with interfaces and is similar
to the many other internal interfaces that we've been adding including
`InternalRegion` and `InternalCache`. Note that we tend to not parameterize
these internal interfaces.
Thanks for the comments. I have done as suggested.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Batches with incomplete transactions when stopping the gateway sender
> ---------------------------------------------------------------------
>
> Key: GEODE-8971
> URL: https://issues.apache.org/jira/browse/GEODE-8971
> Project: Geode
> Issue Type: Improvement
> Components: wan
> Affects Versions: 1.14.0
> Reporter: Alberto Gomez
> Assignee: Alberto Gomez
> Priority: Major
> Labels: pull-request-available
>
> When the gateway sender is stopped there is a high probability that batches
> with incomplete transactions are sent even if group-transaction-events is
> enabled.
> The reason is that once the stop command reaches the gateway sender, it
> immediately stops queueing events, and this could happen in the middle of
> receiving events for the same transaction. If this is the case, some events
> for the transaction may have reached the queue right before the stop command
> was received and the rest of events for that transaction would not make it to
> the queue (they would be dropped) because they arrived right after the stop
> command was received at the gateway sender.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
