[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17230228#comment-17230228
]
ASF GitHub Bot commented on GEODE-8593:
---------------------------------------
davebarnes97 commented on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-725664685
> In general I like simplification of our docs by removing sections
(particularly for seldom used features). However, we should consider adding a
link to an Appendix: Other Features (or similar) or a link to other documents
that discuss those features.
@mmartell I get it, but I think it's beyond the scope of this PR. This PR
does add a "Configuring Pools" topic that did not appear in the previous
version, but that was a side-effect of changing the connection pool code in all
the examples.
I welcome suggestions regarding topics that should be added. Feel free to
contact me directly or open a JIRA ticket with a list so your ideas don't get
lost. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
> ----------------------------------------------------
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
> Affects Versions: 1.13.0
> Reporter: Dave Barnes
> Assignee: Dave Barnes
> Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
> .set("log-level", "debug")
> .set("ssl-enabled", "true")
> .set("ssl-truststore", clientTruststore.string())
> .create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
