[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17231117#comment-17231117
]
ASF GitHub Bot commented on GEODE-8593:
---------------------------------------
codecov-io commented on pull request #689:
URL: https://github.com/apache/geode-native/pull/689#issuecomment-726472518
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=h1)
Report
> Merging
[#689](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=desc)
(5c7d47d) into
[develop](https://codecov.io/gh/apache/geode-native/commit/0e9463d69e7be5455a351eae23b87cef9b2382ac?el=desc)
(0e9463d) will **increase** coverage by `0.03%`.
> The diff coverage is `90.00%`.
[](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #689 +/- ##
===========================================
+ Coverage 74.09% 74.12% +0.03%
===========================================
Files 644 644
Lines 51189 51187 -2
===========================================
+ Hits 37928 37942 +14
+ Misses 13261 13245 -16
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cppcache/src/ThinClientPoolDM.hpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uaHBw)
| `88.70% <ø> (ø)` | |
|
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
| `76.48% <90.00%> (+0.25%)` | :arrow_up: |
|
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
| `62.92% <0.00%> (-2.75%)` | :arrow_down: |
|
[cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==)
| `86.50% <0.00%> (-0.40%)` | :arrow_down: |
|
[cppcache/src/TcrMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuY3Bw)
| `85.62% <0.00%> (-0.16%)` | :arrow_down: |
|
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
| `73.74% <0.00%> (+0.78%)` | :arrow_up: |
|
[cppcache/src/Log.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvZy5jcHA=)
| `57.47% <0.00%> (+0.97%)` | :arrow_up: |
|
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
| `56.66% <0.00%> (+1.12%)` | :arrow_up: |
|
[...tegration-test/testThinClientRemoteRegionQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVJlZ2lvblF1ZXJ5LmNwcA==)
| `83.45% <0.00%> (+1.12%)` | :arrow_up: |
| ... and [3
more](https://codecov.io/gh/apache/geode-native/pull/689/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=footer).
Last update
[0791032...64146b8](https://codecov.io/gh/apache/geode-native/pull/689?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
> ----------------------------------------------------
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
> Affects Versions: 1.13.0
> Reporter: Dave Barnes
> Assignee: Dave Barnes
> Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
> .set("log-level", "debug")
> .set("ssl-enabled", "true")
> .set("ssl-truststore", clientTruststore.string())
> .create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
