[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17229669#comment-17229669
]
ASF GitHub Bot commented on GEODE-8593:
---------------------------------------
mmartell commented on a change in pull request #689:
URL: https://github.com/apache/geode-native/pull/689#discussion_r521040470
##########
File path: docs/geode-native-docs-cpp/regions/regions.html.md.erb
##########
@@ -53,20 +53,20 @@ auto cache = CacheFactory()
cache.getPoolManager()
.createFactory()
- .addLocator("localhost", 10334)
- .create("pool");
+ .addLocator("localhost", 40404)
Review comment:
I would stick with the port 10334 here, which is the default locator
port. 40404 is the default server port, so looks very odd to use as a locator
port.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update native client examples to use Builder pattern
> ----------------------------------------------------
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
> Affects Versions: 1.13.0
> Reporter: Dave Barnes
> Assignee: Dave Barnes
> Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
> .set("log-level", "debug")
> .set("ssl-enabled", "true")
> .set("ssl-truststore", clientTruststore.string())
> .create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
