[
https://issues.apache.org/jira/browse/GEODE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190419#comment-17190419
]
ASF GitHub Bot commented on GEODE-8460:
---------------------------------------
mmartell commented on a change in pull request #647:
URL: https://github.com/apache/geode-native/pull/647#discussion_r483290167
##########
File path: cppcache/acceptance-test/CMakeLists.txt
##########
@@ -0,0 +1,92 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+add_executable(cpp-acceptance-test
+ SNITest.cpp
+)
+
+target_compile_definitions(cpp-acceptance-test
+ PUBLIC
+ GTEST_ELLIPSIS_NEEDS_POD_
+)
+
+target_include_directories(cpp-acceptance-test
+ PUBLIC
+ ${CMAKE_CURRENT_BINARY_DIR}
+)
+
+target_link_libraries(cpp-acceptance-test
+ PUBLIC
+ apache-geode
+ integration-framework
+ testobject
+ ACE::ACE
+ GTest::gtest
+ GTest::gtest_main
+ Boost::boost
+ Boost::system
+ Boost::log
+ Boost::filesystem
+ Boost::chrono
+ PRIVATE
+ _WarningsAsError
+ internal
+)
+
+if(WIN32)
+ foreach (_target apache-geode testobject)
+ add_custom_command(TARGET cpp-acceptance-test
+ DEPENDS ${_target}
+ COMMAND ${CMAKE_COMMAND} -E copy_if_different
+ "$<TARGET_FILE:${_target}>"
+
"$<$<OR:$<CONFIG:Debug>,$<CONFIG:RelWithDebInfo>>:$<TARGET_PDB_FILE:${_target}>>"
+ "$<TARGET_FILE_DIR:cpp-acceptance-test>")
+ endforeach()
+endif()
+
+# file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/sni-test-config DESTINATION
${CMAKE_CURRENT_BINARY_DIR})
+
+set_target_properties(cpp-acceptance-test PROPERTIES
+ CXX_VISIBILITY_PRESET hidden
+ VISIBILITY_INLINES_HIDDEN ON
+ FOLDER cpp/test/acceptance
+)
+
+add_clangformat(cpp-acceptance-test)
+
+enable_testing()
+include(GoogleTest)
+gtest_discover_tests(cpp-acceptance-test
+ DISCOVERY_TIMEOUT 60
+)
+
+file(GLOB SSL_CERTIFICATES
+ "${CMAKE_CURRENT_SOURCE_DIR}/*Keys"
+ )
+
+file(INSTALL ${SSL_CERTIFICATES} DESTINATION ${CMAKE_CURRENT_BINARY_DIR})
Review comment:
Good catch. Indeed this isn't necessary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Configure sni test based on docker availablility
> ------------------------------------------------
>
> Key: GEODE-8460
> URL: https://issues.apache.org/jira/browse/GEODE-8460
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> The SNI tests require docker to be available and configured; therefore, Cmake
> can be used to configure the test(s) to be enabled/disabled appropriately.
>
> Additionally, the tests should be moved to a new test layer as these tests
> are not "integration tests" per se... "acceptance test" is a viable name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
