[
https://issues.apache.org/jira/browse/GEODE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189820#comment-17189820
]
ASF GitHub Bot commented on GEODE-8460:
---------------------------------------
mmartell commented on a change in pull request #647:
URL: https://github.com/apache/geode-native/pull/647#discussion_r482669955
##########
File path: cppcache/integration/test/sni-test-config/docker-compose.yml
##########
@@ -1,43 +0,0 @@
-#
Review comment:
Good catch on the unnecessary geode.properties in the
clicache/acceptance-test folder. Has now been removed. Don't see one in the
cppcache/acceptance-test folder.
The cppcache/integration/test/sni-test-config was removed, as all sni tests
are pulling from sni-test-config that resides in the root folder.
Good catch on the duplicate truststore_sni.pem. It has now been removed. SNI
tests had already been modified to pull this client side truststore from the
ssl_keys/client_keys folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Configure sni test based on docker availablility
> ------------------------------------------------
>
> Key: GEODE-8460
> URL: https://issues.apache.org/jira/browse/GEODE-8460
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> The SNI tests require docker to be available and configured; therefore, Cmake
> can be used to configure the test(s) to be enabled/disabled appropriately.
>
> Additionally, the tests should be moved to a new test layer as these tests
> are not "integration tests" per se... "acceptance test" is a viable name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
