[
https://issues.apache.org/jira/browse/GEODE-8460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17189320#comment-17189320
]
ASF GitHub Bot commented on GEODE-8460:
---------------------------------------
pdxcodemonkey commented on a change in pull request #647:
URL: https://github.com/apache/geode-native/pull/647#discussion_r482166019
##########
File path: cppcache/integration/test/sni-test-config/docker-compose.yml
##########
@@ -1,43 +0,0 @@
-#
Review comment:
Let's get our act together with respect to all these support files for
the SNI tests before we merge this. There's now a geode.properties in _both_
the CLI and the C++ `acceptance-test` directories, are they the same? If so,
they should be in a common area. You've removed the `sni-test-config`
directory from the integration tests, and there's an `sni-test-config` dir at
the top level of the project, are the tests pulling everything from this
directory? There is, at least, a file `truststore_sni.pem` in
`/sni-test-config/geode-config` and there's also one, from earlier refactoring,
in `/ssl_keys/client_keys` - there can be only one! Also, we're installing SSL
certs via INSTALL in CMakeLists.txt. Please don't do this, we spent a lot of
effort removing duplicate SSL certs/keys - tests should always pick these up
from the source directory via defined constants in TestConfig.h or Config.cs.
##########
File path: cppcache/integration/test/CMakeLists.txt
##########
@@ -97,7 +96,7 @@ configure_file(
${CMAKE_CURRENT_SOURCE_DIR}/func_cacheserver2_pool.xml
${CMAKE_CURRENT_BINARY_DIR}/func_cacheserver2_pool.xml COPYONLY)
- file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/sni-test-config DESTINATION
${CMAKE_CURRENT_BINARY_DIR})
+#file(COPY ${CMAKE_CURRENT_SOURCE_DIR}/sni-test-config DESTINATION
${CMAKE_CURRENT_BINARY_DIR})
Review comment:
Please remove commented lines
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Configure sni test based on docker availablility
> ------------------------------------------------
>
> Key: GEODE-8460
> URL: https://issues.apache.org/jira/browse/GEODE-8460
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Ernest Burghardt
> Priority: Major
> Labels: pull-request-available
>
> The SNI tests require docker to be available and configured; therefore, Cmake
> can be used to configure the test(s) to be enabled/disabled appropriately.
>
> Additionally, the tests should be moved to a new test layer as these tests
> are not "integration tests" per se... "acceptance test" is a viable name
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
