[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007565&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007565
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/26 23:27
Start Date: 02/Mar/26 23:27
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875217968
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +399,35 @@ public synchronized void shutdown() throws Exception {
}
}
+ @Override
+ public synchronized void pause() throws Exception {
Review Comment:
I don't really see any benefit to having public pause / resume in the broker
connection API and would instead make these private. The BrokerConnection
already has initialize, start, stop and shutdown and those a pretty clear,
adding pause and resume there doesn't make a ton of sense and they aren't
currently documented to tell an implementation how or why they are different
from start and stop nor are they used anywhere outside of the AMQP broker
connection itself at present.
Issue Time Tracking
-------------------
Worklog Id: (was: 1007565)
Time Spent: 2h 10m (was: 2h)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.53.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
