[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007575&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007575
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 03/Mar/26 00:12
Start Date: 03/Mar/26 00:12
Worklog Time Spent: 10m
Work Description: clebertsuconic commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875365876
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +399,35 @@ public synchronized void shutdown() throws Exception {
}
}
+ @Override
+ public synchronized void pause() throws Exception {
Review Comment:
I have removed it now as I'm not using it.. but pause != stop...
when you pause (from the POV of mirroring) you stop capturing events...
when you stop, you close connections, but you leave the interceptor in place
until the broker goes away... otherwise you may lose messages.
Issue Time Tracking
-------------------
Worklog Id: (was: 1007575)
Time Spent: 3h 40m (was: 3.5h)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.53.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
