[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007571&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007571
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/26 23:34
Start Date: 02/Mar/26 23:34
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2875227318
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java:
##########
@@ -32,6 +33,24 @@ default void shutdown() throws Exception {
// Subclass should override and perform needed cleanup.
}
+ default void pause() throws Exception {
Review Comment:
I don't see any reason to add these here as stated above. You can add them
later as default implementations if they are ever needed outside the
implementation which currently they are not.
Issue Time Tracking
-------------------
Worklog Id: (was: 1007571)
Time Spent: 3h 10m (was: 3h)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.53.0
>
> Time Spent: 3h 10m
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
