[
https://issues.apache.org/jira/browse/ARTEMIS-5925?focusedWorklogId=1007464&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-1007464
]
ASF GitHub Bot logged work on ARTEMIS-5925:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Mar/26 15:34
Start Date: 02/Mar/26 15:34
Worklog Time Spent: 10m
Work Description: tabish121 commented on code in PR #6268:
URL: https://github.com/apache/artemis/pull/6268#discussion_r2873101384
##########
artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/connect/AMQPBrokerConnection.java:
##########
@@ -359,6 +397,37 @@ public synchronized void shutdown() throws Exception {
}
}
+ @Override
Review Comment:
The broker connection already has start / stop and shutdown where stop and
start are effectively already a start of managing this kind of state so adding
these just becomes confusing. These methods would also need synchronization if
added in the same manner as the start and stop correctly do now to prevent
overlapping calls corrupting state while trigger start and stop
##########
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/BrokerConnection.java:
##########
@@ -32,6 +33,24 @@ default void shutdown() throws Exception {
// Subclass should override and perform needed cleanup.
}
+ default void pause() throws Exception {
Review Comment:
Start and Stop are already here to manage this state, pause and resume just
confuse matters
Issue Time Tracking
-------------------
Worklog Id: (was: 1007464)
Time Spent: 1h (was: 50m)
> Support Star Mirror Configuration on Lock Coordinator
> -----------------------------------------------------
>
> Key: ARTEMIS-5925
> URL: https://issues.apache.org/jira/browse/ARTEMIS-5925
> Project: Artemis
> Issue Type: Improvement
> Reporter: Clebert Suconic
> Assignee: Clebert Suconic
> Priority: Major
> Labels: pull-request-available
> Fix For: 2.52.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The Lock Coordinator should be applied to Broker Connections.
> Notice that broker connection should also be made, however mirroring should
> not be capturing events while "paused". This is to guarantee past mirror
> events would be sent after a reconnect. StarMirrorSingleAcceptorRunningTest
> shows the need for this.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
