mohitgurav20 commented on issue #2591: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2591#issuecomment-5852704639
I strongly support this approach. The incremental pure-move strategy is definitely the right path forward to avoid reviewer fatigue and prevent merge conflicts with ongoing dialect PRs. A couple of quick points to ensure smooth execution: 1. **Zero Breaking Changes / API Compatibility:** We should ensure `src/parser/mod.rs` and `src/ast/mod.rs` re-export all moved items (`pub use module::*;`) so downstream consumers (like DataFusion, Polars, ParadeDB, etc.) experience zero breaking changes. 2. **Pure Move Verification Script:** Before starting the refactor PRs, we can write a lightweight CI check/script (e.g., checking symbol re-exports and git line churn) to guarantee that moves are strictly structural with zero logic modifications. I’d be glad to take this on! I can start by drafting the pure-move verification script or handling the first incremental module split (e.g., extracting a specific logical sub-parser from `src/parser/mod.rs`). Please feel free to assign this to me, or let me know where you'd prefer to begin! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
