LucaCappelletti94 opened a new issue, #2591: URL: https://github.com/apache/datafusion-sqlparser-rs/issues/2591
Several source files have grown past the point where navigating them is practical, with the parser mod at over 20k and the ast mod at over 10k. This has come up before. #944 (2023, still open) proposed one parser file per statement, and #1581 (2024) split the whole parser in one draft PR. Both got agreement on the goal, conditioned on a series of small pure-move PRs. The earlier one-shot attempts #344 and #351 (2021) stalled on reviewer bandwidth, with concerns about conflicts with open PRs and about coupled code being easier to read in one file. I suggest we try to do this before the next release, currently roughly planned for end of October (https://github.com/apache/datafusion-sqlparser-rs/issues/2454), as a series of pure move PRs. I believe that, given the size of the task, it may be desirable to: 1. Do this operation in single, reasonably sized PRs 2. Prepare BEFORE a script for the CI that checks that the move is actually a move, and it is complete If agreed, this supersedes #944. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
