theirix commented on code in PR #21737:
URL: https://github.com/apache/datafusion/pull/21737#discussion_r3141880544
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -881,36 +882,41 @@ impl TypeSignature {
}
#[deprecated(since = "46.0.0", note = "See get_example_types instead")]
- pub fn get_possible_types(&self) -> Vec<Vec<DataType>> {
+ pub fn get_possible_types(&self) -> Vec<Vec<NativeType>> {
Review Comment:
Undoubtedly, it's not a replacement now. The question for this improvement
is whether we'd like to provide changes only to the information-schema, which
benefits from native types (then we move code there), or also provide a public
API for the `Signature` to support `NativeType` alongside `DataType` (as now).
At the same time, UDFs are migrating to TypeSignature, abstracting from
physical data types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
