martin-g commented on code in PR #21737:
URL: https://github.com/apache/datafusion/pull/21737#discussion_r3124329748
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -416,11 +417,12 @@ impl TypeSignatureClass {
///
/// This is used for `information_schema` and can be used to generate
/// documentation or error messages.
+ /// Remove with `get_example_types`
Review Comment:
This should be a comment (`//`) instead of rustdoc (`///`)
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -881,36 +882,41 @@ impl TypeSignature {
}
#[deprecated(since = "46.0.0", note = "See get_example_types instead")]
- pub fn get_possible_types(&self) -> Vec<Vec<DataType>> {
+ pub fn get_possible_types(&self) -> Vec<Vec<NativeType>> {
Review Comment:
It seems the NativeType is not powerful enough to fully replace DataType
here.
For example
https://github.com/apache/datafusion/pull/21737/changes#diff-52d29120f24c2a01793f6d729fdb7898abaa8d2320db75aba5cbb06cd714930eR505-R516
shows that there are no counterparts for Union's `UnionMode` and Map's
`keys_sorted` and defaults should be used. And this may lead to confusions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
