theirix commented on code in PR #21737:
URL: https://github.com/apache/datafusion/pull/21737#discussion_r3120111920
##########
datafusion/expr-common/src/signature.rs:
##########
@@ -881,36 +882,41 @@ impl TypeSignature {
}
#[deprecated(since = "46.0.0", note = "See get_example_types instead")]
- pub fn get_possible_types(&self) -> Vec<Vec<DataType>> {
+ pub fn get_possible_types(&self) -> Vec<Vec<NativeType>> {
Review Comment:
@martin-g to avoid breaking changes in the `get_example_types` (my miss),
I've introduced the new method, while deprecating `get_example_types`.
The `Signature` API is heavily `DataType`-based, so the `get_example_types`.
Should we let them coexist, or even move the NativeType-based logic to the
information schema? cc @jayzhan211
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
