adriangb commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-4305174035
@jayshrivastava I'm still seeing two ids in https://github.com/apache/datafusion/pull/20416: ```rust pub struct PhysicalExprId { exact: u64, shallow: Option<u64>, } ``` Please see https://github.com/apache/datafusion/pull/21786/changes/f9b205e662bdcdffc46a20880bbf35954fadff52. I was able to make it work (I think) without two ids. I also realized that this would all still be broken because the execution plan nodes themselves don't restore the dynamic filter after de-serialization, we need to include it. This is now the bulk of https://github.com/apache/datafusion/pull/21786. I also added an e2e integration test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
