gene-bordegaray commented on issue #21207: URL: https://github.com/apache/datafusion/issues/21207#issuecomment-4316982732
> One obvious thing to do would be to add a `Partitioning::Range` variant to [`Partitioning`](https://docs.rs/datafusion/latest/datafusion/physical_expr/enum.Partitioning.html). If Range is not expressive enough, we could add a version implemented via a trait like`Partitioning::Custom(Arc<dyn MyPartitioning>)` Yes I think this is the cleanest apporach long-term. I had proposed something similar here (#18919) a while ago which introduced an idea of Value-based partitioning. Even if the solution we need now is not the exact same, we can continue discussion starting with some ideas from there. I will open a new issue and PR to discuss this separately. Note: There is a very in depth pdf I attached to the PR explaining the partitioning and why it is needed in comparison to `Hash` if anyone is interested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
